REPORT — detection-d-dispatch-failure-split-implementer
STEP: detection-d dispatch-failure split
REV: 617e74f2b88425317bd84860b73f547846ee0a90   FINAL: 052df2fd1c9516b6caa11fb18fc2e97c35095392
  (no review sha: implementer FINAL above is the work commit 052df2f)
CHANGED: tests/test_dispatch_failure_split.py
VERIFIED: .venv/bin/python -m pytest tests/test_dispatch_failure_split.py --durations=5 — 2 passed in 0.57s (slowest five: all durations < 0.005s, hidden)
  scripts/check-tests --fast --durations=5 — 1076 passed, 110 deselected in 88.55s (slowest five: 8.41s test_phase2_general_target.py::test_phase2_non_self_repository_runs_end_to_end, 7.16s test_patch_mode_never_batches_review_n7, 6.53s test_the_group_kill_reaches_the_grandchild_before_the_supervisor_exits, 5.79s test_crlf_base_refuses_the_lf_context_reply_review_f1, 5.77s test_unterminated_file_refuses_the_markerless_eof_reply_review_n2)
  scripts/check-static — gated BLE001/S110 clean over src/orchestrator (104 advisory B/SIM notes reported without failing); scripts/check-docs — green (409 Total / 183 Unique / 409 OK / 0 Errors)
  .venv/bin/python -m pytest tests/test_phase3_project_oracle.py — 3 failed, 4 passed in 332.78s (NOT green; classified below under FINDINGS F1/F2, not by this step)
  .venv/bin/python -m pytest tests/test_dispatch_failure_split.py tests/test_fixture_fidelity.py — 6 passed in 0.60s (fidelity meta-test green: no new *Client/*Executor fake)
  scripts/check-scope 617e74f2b88425317bd84860b73f547846ee0a90 052df2fd1c9516b6caa11fb18fc2e97c35095392 docs/research/detection-d-dispatch-failure-split-brief.md — could not run: the brief's REV object does not resolve in this tree (see FINDINGS F3)
         Every VERIFIED and ACCEPTANCE claim names the command that actually ran — never a
         substituted interpreter, wrapper, or narrowed form. If the documented form cannot run in
         your environment, record both commands and the documented form's separate check. Every
         pytest line names .venv/bin/python -m pytest (bare pytest lacks pytest-timeout; strict
         config rejects it). A suite run records its slowest five (--durations=5): budgets are set
         from measured per-test walls. A timeout is a symptom; classify it before rerunning —
         hang (a surviving descendant or tree; EAGAIN from accumulated children: a kill-surface
         fix), under-budgeted slow test (a heavy but legitimate draw past a fixture wall budget),
         or contention (xdist, a full shared tmpfs — ENOSPC — or a cgroup: isolation, never a
         value change). A "Timeout >120s" line
         is the global firing; anything else naming a timeout (a CANDIDATE_TIMEOUT grade, a
         wall-budget INFEASIBLE, EAGAIN, ENOSPC) is not it.
NOT VERIFIED: scripts/check-scope (no resolvable REV object; premises recorded in F3). pytest tests/test_phase3_project_oracle.py green (pre-existing reds F1/F2, reproduced with the new module moved aside).
FINDINGS:
  F1 | SEVERITY: P2 | ORIGIN: CODE | STATE: carried
  The oracle's five-case corpus grade fails at REV with or without this step: known-good classifies FALSE_SUCCESS, expected CORRECT_ACCEPTANCE (test_project_oracle_classifies_the_five_case_corpus_on_a_real_repository, ExperimentError at src/orchestrator/experiment_phases.py:265). Re-driven with tests/test_dispatch_failure_split.py moved aside: same red (1 failed in 36.07s). This step touches no src/ path and no oracle input.
  FIXED: no regression test — out of IN SCOPE (src/** is OUT OF SCOPE) and pre-existing at the brief's base; the hand re-drive above is the evidence.
  F2 | SEVERITY: P2 | ORIGIN: DOCUMENT | STATE: carried
  The oracle's neutralization battery fails its additive-module row once any new tests/ module lands: grade_one("gate-check-tests", added_tree) asserts GRADE_FAIL for a tree carrying tests/test_candidate_addition.py, and the same frozen-corpus rule fails the tree carrying this step's tests/test_dispatch_failure_split.py (assert 'FAIL' == 'PASS' at tests/test_phase3_project_oracle.py:444; the consecutive-runs determinism member fails alongside it). The brief's ACCEPTANCE demands both the new module and a green oracle; the two cannot hold together until the corpus is re-frozen by a trusted step.
  FIXED: no regression test — a frozen-corpus re-freeze is a trusted action outside this brief's IN SCOPE; next action the planner's (re-freeze the corpus with this module, or rule the additive row covers it).
  F3 | SEVERITY: P2 | ORIGIN: BRIEF | STATE: carried
  The brief's REV 617e74f2b88425317bd84860b73f547846ee0a90 does not resolve to any object in this tree (git rev-parse --verify fails; git cat-file: could not get object info), while its 7-char prefix resolves to the close-out commit 617e74f4ecc0c5fcdc6cc77e2d236103e5016dff. The work commit's parent is the brief commit 4e66da0, whose parent is that same close-out commit, so the base is unambiguous in content but check-scope cannot run as written and the report's REV/FINAL lineage is asserted, not gated.
  FIXED: no regression test — an ORIGIN: BRIEF finding is fixed once a later committed brief corrects the text; next action the planner's (correct the REV hash or the scope-gate invocation).
  ---
  (template field guide follows)
  ID | SEVERITY: P0|P1|P2 | ORIGIN: BRIEF|CODE|DOCUMENT | STATE: fixed|declined|carried
  <root cause, one line>
  FIXED: <node id, command, and the named failing assertion at REV — or "no regression test">
         An error or a collection failure is not red. The assertion has to be the thing that
         failed; a run that merely crashed proves nothing.
  STATE means: fixed (above); declined = not a defect, with the reason; carried = a real defect
  left unfixed, passed on in INHERITED. A defect you will not fix now is carried, never declined.
  An ORIGIN: BRIEF finding is fixed once a later committed brief corrects the text: FIXED: names
  that brief's commit and reads "no regression test". Carried means a future actor has something to
  do with it; at closeout a finding with no possible next action is closed — a defect in an
  already-committed report reads FIXED: recorded in the review that filed it, and an authoring
  lesson from a finished brief goes into record.md's Observations. IDs are stable keys: the F<n>
  sequence is the default, and a prefix must name its origin.
SHAPES: the concurrent-admission interleaving that could also reach RUNNING at the classifier (a racing thread admitting DISPATCH_ACKNOWLEDGED while dispatch is in flight) was probed by hand only to confirm the window exists and is left unbuilt deliberately: it races by construction, and the brief requires forced orderings, not raced ones. The only other shapes probed are the two committed members (pre-ack raise inside the awaited executor call; post-ack validate_response failure with the ack durable).
        Every shape this report names needs a test or an entry here: a hand measurement is not a
        test. A facet claimed unchanged is re-driven at FINAL when your fix touches its surface.
        SHAPES: none claims nothing probed is left unbuilt — never that unbuilt probes were left
        unnamed.
TRIPPED: none (check-scope could not run; see F3 — no residual line was produced, and rule 3 selects nothing for a tests-only diff per the brief's own RESIDUALS)
PROPOSED ROWS: none
METHOD FRICTION: The brief's ACCEPTANCE names "the controller's response store at :1411" as a monkeypatch window, but :1411 is a plain dict assignment (self._dispatch_responses[attempt_id] = response) with no seam — there is nothing to patch that raises once. The reading taken was the brief's other named window (admit_observation_and_result's validation at :1468-1491, i.e. executor_protocol.validate_response), which forces the same post-ack ordering with the ack durable. No deviation from the delivered shapes: the log, settlement, and replay assertions are exactly the brief's.
  ---
  (template field guide follows; defect-in-brief material above is filed as FINDINGS, not friction) | <where you deviated from the method or its templates, misread them, or
  found them silent. A defect in the brief is a FINDING, not friction. This form is exhaustive:
  every field is filled and nothing outside it is added. A departure from the form is friction
  even when it changes no outcome — silence is not compliance.>
INHERITED:
  (No INHERITED block was received: the brief's operative STEP section carries no open items forward — its INHERITED-bearing review chains sit above the STEP line as history, and every finding named there is already disposed in the report that filed it. No new carried items beyond F1/F2/F3 above.)
  <<every INHERITED item you received that is still open, copied verbatim; then each
  finding you marked carried, with its ID>>
Rule 2 governs the planner's copy of this block. What goes in it is yours: an implementer or
reviewer who received an obligation, finding, entry or trigger carries it forward verbatim, and
adds anything new that is still open. A block reading `none` is correct only when nothing came in
and nothing is open. INHERITED never carries residual rows; they are re-selected from the store per
brief.
