REPORT — oracle-gate-identity-scope-review
STEP: oracle-gate-identity-scope
REV: 9302405d3bd94949d03f6586718891ec8d4e7785   FINAL: d796402ab5cc7adc16371118575157ff7337b19e
CHANGED: docs/research/oracle-gate-identity-scope-review.md — this review report (new review test files: none; all probes ran on scratch copies or via stubbed sandboxed_probe, nothing committed under tests/).
VERIFIED: `scripts/check-scope 9302405d3bd94949d03f6586718891ec8d4e7785 d796402ab5cc7adc16371118575157ff7337b19e docs/research/oracle-gate-identity-scope-brief.md` — exit 0, `claimed: src/orchestrator/project_oracle.py tests/test_phase3_project_oracle.py`, `tripped: none`, `scope: ok (3 path(s) in 9302405d3bd94949d03f6586718891ec8d4e7785..d796402ab5cc7adc16371118575157ff7337b19e)`.
VERIFIED: `.venv/bin/python -m pytest tests/test_phase3_project_oracle.py::test_only_the_tests_gate_driver_carries_the_pinned_git_identity tests/test_phase3_project_oracle.py::test_project_oracle_has_no_trusted_gate_bypass_flag tests/test_phase3_project_oracle.py::test_open_defect_identity_normalizes_parameterized_node_ids tests/test_phase3_project_oracle.py::test_registry_identity_floors_reject_compensated_replacements -p no:cacheprovider -q` — 4 passed in 8.21s.
VERIFIED: `.venv/bin/python -m pytest tests/test_phase3_project_oracle.py::test_gate_config_and_test_corpus_neutralization_is_rejected -p no:cacheprovider -q` — 1 passed in 104.97s (the neutralisation member: static ruff bypass FAIL, pytest/conftest bypass FAIL, -k rename bypass FAIL, additive `tests/test_candidate_addition.py` row FAIL, benign source edit PASS on both command gates, broken source FAIL, nested gate-config FAIL).
VERIFIED: `.venv/bin/python -m pytest tests/test_phase3_project_oracle.py::test_project_oracle_classifies_the_five_case_corpus_on_a_real_repository -p no:cacheprovider -q` — 1 passed in 433.83s (five calibration verdicts intact: known-good CORRECT_ACCEPTANCE, unchanged/broken CORRECTLY_UNRESOLVED, known-timeout FALSE_SUCCESS with expect_candidate_timeout gate-check-tests, infrastructure INDETERMINATE).
VERIFIED: `.venv/bin/python -m pytest tests/test_static_gates.py tests/test_milestone8_readiness.py -p no:cacheprovider -q` — 35 passed in 1.82s.
VERIFIED: `scripts/check-tests --fast` — 1076 passed, 111 deselected in 86.76s (gate's own printed line; 111 vs the brief's 110 baseline because the whole oracle module, new member included, is module-marked slow: `pytestmark = pytest.mark.slow` at tests/test_phase3_project_oracle.py:33 — the new member rides deselected with it, so the selected 1076 is unchanged).
VERIFIED: `scripts/check-static` — exit 0 (advisory ruff text prints `Found 104 errors.`; no finding names a line this diff changed).
VERIFIED: `scripts/check-docs` — exit 0: `409 Total / 183 Unique / 409 OK / 0 Errors`.
VERIFIED: R1 re-drive at REV from the pre-image (`git show 9302405:src/orchestrator/project_oracle.py`, template formatted with the unconditional pin): both drivers carry all four vars (`GIT_AUTHOR_NAME/EMAIL`, `GIT_COMMITTER_NAME/EMAIL` = `oracle-gate` / `oracle-gate@localhost`) — R1 shape reproduced. At FINAL through the real `_gate_check` with `sandboxed_probe` stubbed: static formats `env.update({})` with no `GIT_AUTHOR_*`/`GIT_COMMITTER_*` entry anywhere in the driver text, tests formats all four pinned values; `inspect.signature` shows `git_identity` default `None`, the `gate-check-static` call site passes no `git_identity`, the `gate-check-tests` call site passes `_GATE_GIT_IDENTITY`; `dict(git_identity or {})` means the default is genuinely absent, not an empty update masking a drift.
VERIFIED: provenance ground truth — host git config `gituser <a@b.c>` (`/home/ruben/.gitconfig`), `worktree.GIT_ENVIRONMENT` `orchestrator <orchestrator@localhost>` plus fixed dates and R01 config-devnull discipline (`src/orchestrator/worktree.py:38-55`), pin `oracle-gate <oracle-gate@localhost>`; the FINAL comment (src/orchestrator/project_oracle.py:139-149) no longer claims the host's identity — it states the sandbox carries none, the nested suite needs only a valid identity, the pin is a fixed oracle-supplied identity deliberately not the trusted host's, and the static gate receives no pin. Embedded brief copy == committed `docs/research/oracle-gate-identity-scope-brief.md` (exact match).
VERIFIED: behavioral-red mutant — the new member's logic against the REV pre-image loaded as `orchestrator.rev_project_oracle`: REV static map carries all four (member's `== {}` assertion RED) and REV `_gate_check` has no `git_identity` parameter (`TypeError: _gate_check() got an unexpected keyword argument 'git_identity'`), so the member fails at REV on the static driver's non-empty identity and passes at FINAL — a true behavioral red, not an echo. Monkeypatch scope: exactly one `monkeypatch.setattr(project_oracle, "sandboxed_probe", capture)` with a function-local `captured` dict; nothing module-global is written, and the new member passes standalone in 0.11s.
VERIFIED: diff limited — `9302405..d796402 --name-only` is exactly the brief file (planner commit), `src/orchestrator/project_oracle.py`, `tests/test_phase3_project_oracle.py`; the src diff is the `git_identity: Optional[Mapping] = None` parameter plus `dict(git_identity or {})` plus the comment plus the one tests call-site kwarg; the test diff is `import ast`, `import types`, the `_driver_identity` helper, and the one new member. No freeze input, registry, or `worktree.py` move.
NOT VERIFIED: the full 8-member oracle module in one run (corpus ~434s + neutralisation ~105s members were run individually above; the implementer's report covers the whole-module 8-passed ACCEPTANCE run at 771.94s).
FINDINGS: none
SHAPES: none — every shape this review probed is built by the suite or was re-driven above from the formatted drivers: the REV both-carry shape (pre-image format), the FINAL split (real `_gate_check` format for both call sites), the REV-red mutant (pre-image module load), the additive row (neutralisation member's added-module branch), the five calibration verdicts (corpus member), and the provenance ground truth (host config + GIT_ENVIRONMENT + pin comparison). No unbuilt probe remains.
TRIPPED: none
PROPOSED ROWS: none
METHOD FRICTION: none
INHERITED:
none
