REPORT — phase4-recursive-planning-integration-api-shape-implementer
STEP: phase4-recursive-planning-integration-api-shape (Phase 4: the admission capability, the two mint points, and the constructor rename)
REV: 41ec3303c9c184138f5ca3201f40fc00ba9ce7de   FINAL: 98988d44515cb0f088885c3b6d5f6f6c051c6fec
CHANGED: src/orchestrator/controller.py — the non-data `AdmissionCapability` (module-private mint nonce plus a digest of the admitted children), `_mint_admission_capability`, the capability requirement at `Controller.propose_decomposition`, and `Controller.admit_derived_decomposition`, the derived-only entry the deterministic derivation path uses. The aborted attempt's partial edits in this file are folded in and revised; this commit is their final state.
CHANGED: src/orchestrator/planning_pilot.py — `admit_proposal` is the guarded mint point: it mints over exactly the structures it admitted and returns `(children, capability)`; `propose_decomposition` returns `(payload, record, capability)`, the capability travelling beside the payload and never inside it. The aborted attempt's partial import is folded in.
CHANGED: src/orchestrator/trial_driver.py — `_route_decomposition` unpacks the capability beside the producer payload and `_admit_routed_decomposition` passes it to the model-routed `propose_decomposition`; `_admit_decomposition` (the un-routed derived admission at the rename's call surface) calls `admit_derived_decomposition`.
CHANGED: src/orchestrator/conformance.py — the two corpus recordings (`decomp-1` with dependencies, `decomp-2`) use the derived-only entry.
CHANGED: tests/test_planning_pilot.py — the call surface of the two return signatures (`admit_proposal`'s `(children, capability)`, the producer's `(payload, record, capability)`), and one test per named shape: `TestAdmissionCapabilityIsRequired` (Capability), `TestTheOnlyTwoMintPoints` (Two-mint-point, named for both mint points), `TestDigestBinding` (Digest-binding), `TestDerivedOnlyNaming` (Derived-only naming, both routes over DECOMPOSITION_ADMITTED payloads, run-limit checks, and dependency edges), `TestNoMarkerField` (No-marker).
CHANGED: tests/test_planning_pilot_routing.py — the fixture spy forwards the producer's three-value return; `test_admitted_payload_is_forwarded_unmutated` itself is byte-identical and stands unchanged as the Transit immutability pin (the file diff is the spy only).
CHANGED: tests/test_review_depth_walk.py — F6's two pins renamed to state the enforced property (`test_the_root_reads_depth_zero_and_a_true_depth_two_leaf_reads_two_and_subtree_height_is_not_depth`, `test_the_pilot_depth_guard_refuses_a_proposal_at_a_true_depth_two_node_at_bounds`); the four admission call sites use the derived-only entry; the guard pin unpacks the producer's three-value return.
CHANGED: tests/test_crash_recovery.py — the interrupted-decomposition fixture uses the derived-only entry (1 call site).
CHANGED: tests/test_crash_matrix.py — both scripted decomposition workflows use the derived-only entry (2 call sites).
CHANGED: tests/test_batch5_recovery.py — the budget-exhaustion batch workflow uses the derived-only entry (1 call site).
CHANGED: tests/test_milestone2_acceptance.py — the seven admission call sites use the derived-only entry; `test_propose_decomposition_blocks_dependents_only` is renamed `test_admitted_decomposition_blocks_dependents_only` so its name does not name the retired unguarded call it no longer makes (see F8).
CHANGED: tests/test_milestone8_readiness.py — the node-limit fixture uses the derived-only entry (1 call site).
VERIFIED: scripts/check-tests --fast — 960 passed, 45 deselected in 91.26s (0:01:31).
VERIFIED: pytest tests/test_planning_pilot.py tests/test_planning_pilot_routing.py tests/test_review_depth_walk.py — 164 passed in 11.28s.
VERIFIED: pytest tests/test_crash_recovery.py tests/test_crash_matrix.py tests/test_batch5_recovery.py — 17 passed in 1.09s.
VERIFIED: pytest tests/test_milestone2_acceptance.py tests/test_milestone8_readiness.py — 41 passed in 1.46s.
VERIFIED: pytest tests/test_milestone2_conformance.py tests/test_milestone3_conformance.py — 70 passed in 0.49s.
VERIFIED: pytest tests/test_phase3_project_oracle.py — 5 passed in 283.38s (0:04:43).
VERIFIED: scripts/check-static — exit 0 ("All checks passed!" on the gated select; the B/SIM advisory report does not gate).
VERIFIED: scripts/check-docs — exit 0 (315 links, 0 errors).
VERIFIED: scripts/check-scope 41ec3303c9c184138f5ca3201f40fc00ba9ce7de 98988d44515cb0f088885c3b6d5f6f6c051c6fec docs/research/phase4-recursive-planning-integration-api-shape-brief.md — scope: ok (13 path(s)).
NOT VERIFIED: none — every claim below is covered by a run named above; F6's FIXED line reads `no regression test` because a name defect has no failing assertion to name (both renamed bodies were green at REV under their wrong names, per the fixes step's VERIFIED).
FINDINGS:

F6 | SEVERITY: P2 | ORIGIN: CODE | STATE: fixed
  Two absorbed pins keep names that state the bug's behaviour, opposite to what they enforce.
  FIXED: no regression test — tests/test_review_depth_walk.py's two pins renamed to `test_the_root_reads_depth_zero_and_a_true_depth_two_leaf_reads_two_and_subtree_height_is_not_depth` and `test_the_pilot_depth_guard_refuses_a_proposal_at_a_true_depth_two_node_at_bounds` (their assertions are unchanged and were green at REV; the defect is the names, so there is no failing assertion at REV to name). The Pin-name shape is the rename itself; the third pin's name already states its property.

F8 | SEVERITY: P2 | ORIGIN: BRIEF | STATE: carried
  The rename mandate names only F6's two pins and is silent about in-scope test identifiers that embed the retired unguarded entry name: retargeting `test_propose_decomposition_blocks_dependents_only` to `admit_derived_decomposition` without renaming it would re-open F6's class (a name stating `propose_decomposition` over a call that no longer makes it). Exactly one reading is consistent with the Pin-name shape's name-states-the-enforced-property rule — such identifiers are renamed with the entry — and this step took it: the test is `test_admitted_decomposition_blocks_dependents_only` (tests/test_milestone2_acceptance.py).
  FIXED: no regression test — an ORIGIN: BRIEF finding is fixed once a later committed brief states the rule in text; none has at this commit, so this is carried into the closeout for the ruling rather than declined.
SHAPES: none — the five capability shapes are tests in tests/test_planning_pilot.py, each named for its shape (`TestAdmissionCapabilityIsRequired`, `TestTheOnlyTwoMintPoints`, `TestDigestBinding`, `TestDerivedOnlyNaming`, `TestNoMarkerField`); the Transit immutability shape is the unchanged pin `tests/test_planning_pilot_routing.py::test_admitted_payload_is_forwarded_unmutated`; the Pin-name shape is tests/test_review_depth_walk.py's two renamed pins. Nothing probed by hand was left unbuilt.
TRIPPED: PILOT-R1 PILOT-R2 PILOT-R3 PILOT-R4 PILOT-R5 PILOT-R6 PILOT-R10 PILOT-R10 — copied from check-scope's `tripped:` line, verbatim (`PILOT-R10` is listed twice because both of its trigger paths matched the diff; recomputing would have dropped it once, which is the F7 mis-vote). The seven rows are accepted risks whose triggers matched (`planning_pilot.py`, `controller.py`); they are carried into the closeout with the reasons recorded in docs/residuals.md, and rule 2 keeps the rows out of INHERITED and PROPOSED. The digest binding this step adds is the named Digest-binding shape's refusal of a post-mint mutation — it does not close `PILOT-R1`, whose mutable admitted payload and reducer re-validation stand as recorded.
PROPOSED ROWS: none (the planner maintains docs/residuals.md).
METHOD FRICTION: none against the method's steps. Two template points are worth the method's attention: (1) the report template's `REV: <base sha>` is ambiguous when the brief's `REV` (the step's base, the check-scope range start) is not `FINAL`'s parent — this brief's own REV note resolves it ("is not claimed to be FINAL's parent"), and this report's `REV` names the range base as the previous implementer report did; the template could name which of the two it wants. (2) The template is silent on a brief revised under a dispatched implementer: this brief was re-cut per R7 and its history rewritten while this step was already implementing it. The GOAL and named shapes are unchanged between the dispatched and current texts, so the work needed no revision, but the acceptance command list changed shape and was re-run as the current brief names it (the phase-3 oracle was added). A template note that a re-dispatch supersedes the running text, or that the implementer re-reads the brief before committing, would close the gap.
INHERITED:

F7 | SEVERITY: P2 | ORIGIN: DOCUMENT | STATE: carried
  The implementer report's residual accounting mis-votes TRIPPED (names `PILOT-R2`, omits `PILOT-R1`/`PILOT-R10`).

R7 withdrew F7's INHERITED half as a finding against correct behaviour — rule 3 selects residuals per brief, and the implementer's exclusion of the seven rows was right — so F7 stands only as its wrong-`TRIPPED` half, quoted above.

F8 | SEVERITY: P2 | ORIGIN: BRIEF | STATE: carried
  The rename mandate names only F6's two pins and is silent about in-scope test identifiers that embed the retired unguarded entry name: retargeting `test_propose_decomposition_blocks_dependents_only` to `admit_derived_decomposition` without renaming it would re-open F6's class (a name stating `propose_decomposition` over a call that no longer makes it). Exactly one reading is consistent with the Pin-name shape's name-states-the-enforced-property rule — such identifiers are renamed with the entry — and this step took it: the test is `test_admitted_decomposition_blocks_dependents_only` (tests/test_milestone2_acceptance.py).
  FIXED: no regression test — an ORIGIN: BRIEF finding is fixed once a later committed brief states the rule in text; none has at this commit, so this is carried into the closeout for the ruling rather than declined.
