REPORT — phase5-run-entry-fixes-3-implementer
STEP: phase5-run-entry-fixes-3 (the last run-entry fixes — F26–F28)
REV: 6ad098906d6e180e4bff3a5362f1c030ba42230b   FINAL: 010142264aeaadbfdee24b61131a15956e6ffc94
CHANGED: src/orchestrator/controller.py — mark_infeasible reads failure_fingerprints and raises a bare WorkflowError before emitting when none are recorded; docstring records the enforced guard.
CHANGED: docs/run-entry.md — Commands heads become the `python3 scripts/orchestrate.py …` form; the system-`python3`-must-resolve-`yaml` prerequisite and the no-bare-head rule are named.
CHANGED: tests/test_phase5_run_entry_fixes_2_review.py — the F27 probe asserts `pytest.raises(WorkflowError)` with node, outcome, and history unchanged; the F28 probe asserts the documented-form property (heads, prerequisite, no bare head, the form runs).
VERIFIED: scripts/check-tests --fast — 961 passed, 85 deselected, 70.20s, exit 0
VERIFIED: .venv/bin/python -m pytest tests/test_run_entry.py tests/test_phase5_run_entry_fixes_2_review.py — 40 passed, 13.24s, exit 0
VERIFIED: .venv/bin/python -m pytest tests/test_milestone2_conformance.py — 41 passed, 0.22s, exit 0
VERIFIED: .venv/bin/python -m pytest tests/test_phase3_project_oracle.py — 5 passed, 261.15s, exit 0
VERIFIED: scripts/check-static — exit 0 (BLE001/S110 gate clean; B/SIM advisory rows reported without failing)
VERIFIED: scripts/check-docs — table verification passed, links 350/350 OK, exit 0
VERIFIED: scripts/check-scope 6ad098906d6e180e4bff3a5362f1c030ba42230b 010142264aeaadbfdee24b61131a15956e6ffc94 docs/research/phase5-run-entry-fixes-3-brief.md — tripped: PILOT-R1 PILOT-R10; scope: ok (4 paths), exit 0
VERIFIED: Red evidence at REV 6ad0989, replayed in a scratch worktree (the previous review's own committed probes): test_review_f27_mark_infeasible_requires_no_failure_history red at `AssertionError: F27: mark_infeasible admitted a terminal decision for a lineage with zero recorded failures, driving the run outcome to 'INFEASIBLE' from the prose guard alone` / `assert 'INFEASIBLE' != 'INFEASIBLE'` (tests/test_phase5_run_entry_fixes_2_review.py:112); test_review_f28_documented_bare_command_is_executable red at `assert os.access(_SCRIPT, os.X_OK)` / `assert False` (line 128). Both green at FINAL.
NOT VERIFIED: none
FINDINGS:
  F26 | SEVERITY: P2 | ORIGIN: BRIEF | STATE: fixed
  The fixes-2 brief's GOAL named `import orchestrator.experiment.trial_driver` as the dotted-import row "red at the delivered helper", but that leaf is already forbidden, so the row is green and cannot demonstrate the fix.
  FIXED: no regression test — this brief's GOAL corrects the row to `import orchestrator.experiment_spec.sub` (forbidden module interior, non-forbidden leaf) and records that `import orchestrator.experiment.trial_driver` is green at a leaf-only helper; the correction is committed in the brief commit 93044848c0ce2eb1ab2f0706cb5797830602b749.
  F27 | SEVERITY: P2 | ORIGIN: CODE | STATE: fixed
  `Controller.mark_infeasible` admitted a terminal `NODE_MARKED_INFEASIBLE` decision with its only guard ("Deterministic infeasibility policy passes") evaluated nowhere — a zero-recorded-failure lineage could drive the run outcome to INFEASIBLE on prose alone.
  FIXED: tests/test_phase5_run_entry_fixes_2_review.py::test_review_f27_mark_infeasible_requires_no_failure_history — at REV the named assertion failed: "F27: mark_infeasible admitted a terminal decision for a lineage with zero recorded failures … assert 'INFEASIBLE' != 'INFEASIBLE'". The surface now raises a bare `WorkflowError` when `state.failure_fingerprints.get(node_id)` is empty, before any event is admitted; green at FINAL.
  F28 | SEVERITY: P2 | ORIGIN: DOCUMENT | STATE: fixed
  `docs/run-entry.md`'s Commands section documented the bare `scripts/orchestrate.py …` heads as runnable, but the delivered script is mode 100644, so the documented form cannot run as written and neither the executable-bit/`python3` requirement nor the system-interpreter `yaml` prerequisite was named.
  FIXED: tests/test_phase5_run_entry_fixes_2_review.py::test_review_f28_documented_bare_command_is_executable — at REV the named assertion failed at `os.access(_SCRIPT, os.X_OK)`. The section is rewritten to the `python3 scripts/orchestrate.py …` form the clean-env pin executes, names the `yaml` prerequisite and the no-bare-head rule, and the probe runs the documented form (`--help`, exit 0); green at FINAL.
SHAPES: none — both named shapes are built: the Guarded-surface shape by the absorbed F27 probe (refusal), with the accepted-lineage duplicate-dedup and terminal-run late-retention facets unchanged as measured by the fixes-2 review (late retention is also covered by test_review_settle_gap_adversarial_order_keeps_document_fresh); the Runnable-doc shape by the absorbed F28 probe plus test_clean_env_cli_shape running the same form.
TRIPPED: PILOT-R1 PILOT-R10
PROPOSED ROWS: none
METHOD FRICTION: none
INHERITED:
none — every received INHERITED item (F26, F27, F28) is fixed by this step; nothing is carried.
